Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI libraries in fronted added #1970

Merged
merged 3 commits into from
Oct 15, 2023
Merged

UI libraries in fronted added #1970

merged 3 commits into from
Oct 15, 2023

Conversation

hritikbhattacharya
Copy link
Contributor

Closes #1927

Changes proposed

added a sub category in Frontend section named UI Libraries.

@vercel
Copy link

vercel bot commented Oct 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 7:19pm

github-actions[bot]
github-actions bot reviewed Oct 12, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, hritikbhattacharya, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Anmol-Baranwal
Anmol-Baranwal requested changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hritikbhattacharya

Please add a description for UI Libraries as a subcategory.

image

@hritikbhattacharya
Copy link
Contributor Author

ok

@Anmol-Baranwal
Copy link
Collaborator

@hritikbhattacharya
You don't need to rush or anything.

Just do it whenever you have time, we will just review it after you do the changes.

@hritikbhattacharya
Copy link
Contributor Author

hritikbhattacharya commented Oct 12, 2023 •
edited
Loading

@Anmol-Baranwal
In which folder the description of subcategory needed to be added, I didn't able to find it. would please help.

@Anmol-Baranwal
Copy link
Collaborator

@hritikbhattacharya
You can find it here: https://github.com/rupali-codes/LinksHub/blob/main/components/TopBar/CategoryDescriptions.ts

TopBar/CategoryDescriptions.ts

@hritikbhattacharya
Copy link
Contributor Author

thanks for the help.

CBID2
CBID2 requested changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hritikbhattacharya! :) I pointed out a proofreading error in my inline comment. In the future, consider running your descriptions through Grammarly or Spellcheck before making a pull request. Other than that, you're off to a great start! :)

Anmol-Baranwal
Anmol-Baranwal approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me.

@CBID2
Please review this again. I think he updated the descriptions.

CBID2
CBID2 approved these changes Oct 14, 2023
View reviewed changes
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @hritikbhattacharya! @rupali-codes, it's your turn! 😊

@CBID2 CBID2 added goal: new-link Addition of new links related contributions status: ready-to-merge Approved & its ready-to-merge priority: low Addition of new links/categories or doing any small task (e.g fixing typos) hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest labels Oct 14, 2023
rupali-codes
rupali-codes approved these changes Oct 15, 2023
View reviewed changes
Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rupali-codes rupali-codes merged commit 6c89020 into rupali-codes:main Oct 15, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@CBID2 CBID2 CBID2 approved these changes

@rupali-codes rupali-codes rupali-codes approved these changes

@Anmol-Baranwal Anmol-Baranwal Anmol-Baranwal approved these changes

Assignees

@hritikbhattacharya hritikbhattacharya

Labels
goal: new-link Addition of new links related contributions hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest priority: low Addition of new links/categories or doing any small task (e.g fixing typos) status: ready-to-merge Approved & its ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ADD] <FRONTEND/UIcomponents>
4 participants
@hritikbhattacharya @Anmol-Baranwal @rupali-codes @CBID2